Add support for enforcing angular.mock.module#567
Open
tomratcliffe wants to merge 1 commit intoEmmanuelDemey:developmentfrom
Open
Add support for enforcing angular.mock.module#567tomratcliffe wants to merge 1 commit intoEmmanuelDemey:developmentfrom
tomratcliffe wants to merge 1 commit intoEmmanuelDemey:developmentfrom
Conversation
This is needed when migrating angular.js to use webpack, and the existing unit tests call `module('myModule')`. This causes problems as `module` is a reserved/special word for webpack use, and the unit tests won't compile. The solution is to use `angular.mock.module('myModule')`. This rule change adds a `webpack-support` option (open to renaming this), and adds a fixer that can sort out the problems found (to save on Ctrl+F'ing through the code and finding issues).
Author
|
Hi @EmmanuelDemey, have you had a chance to look at this yet? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed when migrating angular.js to use webpack, and the existing unit tests call
module('myModule'). This causes problems asmoduleis a reserved/special word for webpack use, and the unit tests won't compile (complaining thatmodule is not a function). The solution is to useangular.mock.module('myModule'). This rule change adds awebpack-supportoption (open to renaming this), and adds a fixer that can sort out the problems found (to save on Ctrl+F'ing through the code and finding issues).Please see the following for more context/examples:
https://stackoverflow.com/questions/32499108/karma-jasmine-webpack-module-is-not-a-function
https://stackoverflow.com/questions/39360164/module-is-not-a-function-karma-jasmine-webpack-angular?rq=1